Fix some tests to match retired stats modes and wrong config file ordering

2 files changed, 22 insertions, 8 deletions

diff --git a/tests/integration/test_stats.py b/tests/integration/test_stats.py
index 7ff9a38..820b917 100644
--- a/tests/integration/test_stats.py
+++ b/tests/integration/test_stats.py
@@ -16,8 +16,7 @@ from harness import TrackerTestCase
 
 # The modes a default build answers. "tpbs" and "statedump" are full scrapes
 # and belong to test_fullscrape; "fulllog" and "woodpeckers" sit behind
-# feature flags this build does not set; "busy" is advertised but unbuilt,
-# which the next case pins.
+# feature flags this build does not set.
 MRTG_MODES = ["peer", "conn", "scrp", "udp4", "tcp4", "torr", "fscr", "completed", "syncs"]
 TEXT_MODES = ["herr", "s24s", "top10", "top100", "renew", "version"]
 
@@ -36,14 +35,14 @@ class StatsShape(TrackerTestCase):
             for line in lines[:2]:
                 self.assertRegex(line, rb"^\d+$", "mode %s line %r" % (mode, line))
 
-    def test_the_busy_mode_is_advertised_but_not_built(self):
-        """TASK_STATS_BUSY_NETWORKS is in the enum and in the mode table, and
-        no switch anywhere handles it, so the worker frees the empty answer
-        and the request ends as a server error. Pinned rather than blessed:
-        either the report gets written or the mode leaves the table."""
+    def test_the_busy_mode_is_gone(self):
+        """It was listed in the mode table and implemented nowhere, so it only
+        ever answered 500. Removed rather than written: picking poisoning
+        networks out stopped being meaningful once consumer lines became bot
+        hosts and v6 made the address space too large to watch."""
         with self.assertRaises(urllib.error.HTTPError) as caught:
             self.tracker.stats("busy")
-        self.assertEqual(caught.exception.code, 500)
+        self.assertEqual(caught.exception.code, 400, "an unknown mode, like any other")
 
     def test_an_unknown_mode_is_refused(self):
         with self.assertRaises(urllib.error.HTTPError) as caught:
diff --git a/tests/integration/test_udp.py b/tests/integration/test_udp.py
index 1dfa21b..1cb2389 100644
--- a/tests/integration/test_udp.py
+++ b/tests/integration/test_udp.py
@@ -149,5 +149,20 @@ class UdpScrape(TrackerTestCase):
             sock.close()
 
 
+class UdpWorkersConfiguredAfterTheListener(TrackerTestCase):
+    """The harness writes its listen lines first, so this directive lands
+    below them: the position a config file should not care about."""
+
+    config = "listen.udp.workers 4\n"
+
+    def test_the_tracker_starts_and_still_answers_udp(self):
+        sock, connection_id = self.tracker.udp_connect()
+        try:
+            answer = self.tracker.udp_announce(sock, connection_id, self.hash_for("udpworkers"), left=0)
+            self.assertEqual(answer["seeders"], 1)
+        finally:
+            sock.close()
+
+
 if __name__ == "__main__":
     unittest.main()