From 4ece9d359fd6668bfbc9c4260463f5b5913ae8fc Mon Sep 17 00:00:00 2001 From: Dirk Engling Date: Fri, 23 Oct 2026 22:16:25 +0200 Subject: Avoid returning the result of void functions --- ot_vector.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'ot_vector.c') diff --git a/ot_vector.c b/ot_vector.c index 7f661aa..e3c3d3f 100644 --- a/ot_vector.c +++ b/ot_vector.c @@ -218,8 +218,10 @@ void vector_redistribute_buckets(ot_peerlist *peer_list, size_t peer_size) { for (bucket = 0; bucket < num_buckets_new; ++bucket) { bucket_list_new[bucket].space = bucket_size_new; bucket_list_new[bucket].data = malloc(bucket_size_new * peer_size); - if (!bucket_list_new[bucket].data) - return vector_clean_list(bucket_list_new, num_buckets_new); + if (!bucket_list_new[bucket].data) { + vector_clean_list(bucket_list_new, num_buckets_new); + return; + } } /* Now sort them into the correct bucket */ @@ -232,8 +234,10 @@ void vector_redistribute_buckets(ot_peerlist *peer_list, size_t peer_size) { bucket_dest += vector_hash_peer(peers_old, OT_PEER_COMPARE_SIZE_FROM_PEER_SIZE(peer_size), num_buckets_new); if (bucket_dest->size + 1 > bucket_dest->space) { void *tmp = realloc(bucket_dest->data, peer_size * OT_VECTOR_GROW_RATIO * bucket_dest->space); - if (!tmp) - return vector_clean_list(bucket_list_new, num_buckets_new); + if (!tmp) { + vector_clean_list(bucket_list_new, num_buckets_new); + return; + } bucket_dest->data = tmp; bucket_dest->space *= OT_VECTOR_GROW_RATIO; } -- cgit v1.3