From 1f26001944702312c9ae7d7a047589543cbf8e30 Mon Sep 17 00:00:00 2001 From: Dirk Engling Date: Mon, 2 Nov 2026 03:09:20 +0100 Subject: Remove tracker id from stats, as well --- ot_stats.c | 2 -- tests/integration/test_stats.py | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ot_stats.c b/ot_stats.c index 8771f0c..a2eb084 100644 --- a/ot_stats.c +++ b/ot_stats.c @@ -4,7 +4,6 @@ $id$ */ /* System */ -#include #include #include #include @@ -513,7 +512,6 @@ static void stats_return_everything(char **reply, const char *reply_end) { fmt_append(reply, reply_end, "\n"); fmt_append(reply, reply_end, "\n"); - fmt_append(reply, reply_end, " %" PRIu32 "\n", g_tracker_id); fmt_append(reply, reply_end, " %llu\n", (unsigned long long)(time(NULL) - ot_start_time)); fmt_append(reply, reply_end, " \n"); fmt_append(reply, reply_end, " %zd\n", mutex_get_torrent_count()); diff --git a/tests/integration/test_stats.py b/tests/integration/test_stats.py index 74f6d47..088d8a1 100644 --- a/tests/integration/test_stats.py +++ b/tests/integration/test_stats.py @@ -66,6 +66,12 @@ class StatsShape(TrackerTestCase): def test_everything_does_not_name_the_build(self): self.assertNotIn(b"opentracker 1", self.tracker.stats("everything")) + def test_everything_does_not_name_the_tracker_id(self): + """The id a tracker recognises its own live sync packets by. Knowing + it is of no use to a client and of some use to whoever would like a + tracker to discard what it is told.""" + self.assertNotIn(b"tracker_id", self.tracker.stats("everything")) + class StatsCount(TrackerTestCase): def test_the_torrent_count_follows_the_torrents(self): -- cgit v1.3